github / github/hotkey

Add support for chords to mapper tool

Offen
#89 0 Kommentare 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
JavaScript
Sterne
3.3k
Forks
99
Ø Merge
14 Std. 22 Min.
Gemergte PRs (30 T.)
6

Beschreibung

It would be great if we could also display chords in the mapper tool, similarly to VSCode.

I dug into this a bit and it's more complicated than I expected. If you just have a timer and track keydown events, you get chords like Meta Meta+b because the keydown for Meta is different from the keydown for b. It looks like this is solved in the main code with the 'radix trie' logic, but this seems pretty closely tied to the hotkeys that are configured on the element, and we can't configure _all_ possible hotkeys onto the mapper tool.

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start by tracing the mapper tool and the main code's radix trie logic described in the issue, then compare how VSCode displays chords. Determine how modifier and keydown events should be grouped when all possible hotkeys cannot be configured on the mapper; done means the mapper displays chords without duplicate modifier entries.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
javascript
Bereich
frontend, tooling
Issue-Typ
Feature
Schwierigkeit
5/5
Geschätzter Aufwand
Über eine Woche
Aktivitätsstatus
Veraltet
Klarheit
Muss geklärt werden
Anfängerfreundlichkeit
30/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.