github / github/github-ds

expires_at is stored as a database datetime column

未關閉
#62 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Ruby
星號
700
分支
29
PR 合併指標
30 天內沒有已合併 PR

描述

### Context
During the DST to standard time change, when the SQL server is running in a local time zone, records cannot be found when `expires_at` is set to 1 hour.

Given a PST time and a fallback to standard time at 2 AM, 1 hour from 1 AM, is going to be still 1 AM. The date s converted to the same date that was entered and few seconds after the record cannot be found again.

The `expires_at` column should be timezone agnostic, possible solution would be to store it as an integer (epoch time),

貢獻指南

開啟貢獻指南

研究方向

Start at the model or schema definition for expires_at and ActiveRecord's datetime conversion, then reproduce the DST fallback with the SQL server in a local timezone. Done means expiration remains findable across the fallback, with timezone-agnostic storage and regression coverage agreed.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
rails, ruby
領域
database
Issue 類型
缺陷
難度
4/5
預估耗時
3-5 天
活躍度
停滯
描述清晰度
基本清楚
新手友好度
30/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。