github / github/github-ds

expires_at is stored as a database datetime column

Ouverte
#62 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Ruby
Étoiles
700
Forks
29
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

### Context
During the DST to standard time change, when the SQL server is running in a local time zone, records cannot be found when `expires_at` is set to 1 hour.

Given a PST time and a fallback to standard time at 2 AM, 1 hour from 1 AM, is going to be still 1 AM. The date s converted to the same date that was entered and few seconds after the record cannot be found again.

The `expires_at` column should be timezone agnostic, possible solution would be to store it as an integer (epoch time),

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Start at the model or schema definition for expires_at and ActiveRecord's datetime conversion, then reproduce the DST fallback with the SQL server in a local timezone. Done means expiration remains findable across the fallback, with timezone-agnostic storage and regression coverage agreed.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
rails, ruby
Domaine
database
Type d'issue
Bug
Difficulté
4/5
Temps estimé
3-5 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
30/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.