github / github/gh-stack

Incorrect "PR #5 remains open" remains open after git stack modify for a PR that is already closed

未关闭
#453 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
bug topic: cli - modify
主要语言
Go
星标
1.5k
派生
70
平均合并
1 天 8 小时
30 天内合并 PR
7

描述

1. Use `gs submit` to create stack with depth 2. Let's say branch names `layer1` and `layer2`
2. I close the PR for `layer2` in the GitHub UI
3. I want to remove the stack locally, so I use `git stack modify`, press `x` to delete the layer, and then `Control+S` to save.

I get the following output
```
$ gs modify
✓ Dropped layer2 from stack

✓ Stack modified successfully
Dropped: layer 2(PR #53155 remains open — close with `gh pr close 53155`)

Run `gh stack submit` to push your changes and update the stack of PRs on GitHub
```

Now `gh` cli can clearly tell the PR is already closed, because when I try to close it:
```
$ gh pr close 53155
! Pull request repo#53155 (PR Title) is already closed
```

I think a fix will be doing a resync on the state from GitHub before showing this message.

贡献指南

打开贡献指南

调研方向

Start with the `git stack modify` save flow, including the `gs modify` output that reports a dropped layer as still open. Check how the GitHub PR state is obtained before that message; done when a PR already closed in GitHub is not reported as open after the layer is deleted.

由索引模型根据 Issue 内容生成。

评估

技术栈
github, go
领域
api, cli
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
活跃
描述清晰度
基本清楚
新手友好度
65/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。