github / github/gh-stack

Incorrect "PR #5 remains open" remains open after git stack modify for a PR that is already closed

Abierto
#453 0 comentarios 0 reacciones 0 asignados Ver en GitHub
bug topic: cli - modify
Lenguaje dominante
Go
Estrellas
1.5k
Forks
70
Merge medio
1 d 8 h
PR fusionados (30 d)
7

Descripción

1. Use `gs submit` to create stack with depth 2. Let's say branch names `layer1` and `layer2`
2. I close the PR for `layer2` in the GitHub UI
3. I want to remove the stack locally, so I use `git stack modify`, press `x` to delete the layer, and then `Control+S` to save.

I get the following output
```
$ gs modify
✓ Dropped layer2 from stack

✓ Stack modified successfully
Dropped: layer 2(PR #53155 remains open — close with `gh pr close 53155`)

Run `gh stack submit` to push your changes and update the stack of PRs on GitHub
```

Now `gh` cli can clearly tell the PR is already closed, because when I try to close it:
```
$ gh pr close 53155
! Pull request repo#53155 (PR Title) is already closed
```

I think a fix will be doing a resync on the state from GitHub before showing this message.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Start with the `git stack modify` save flow, including the `gs modify` output that reports a dropped layer as still open. Check how the GitHub PR state is obtained before that message; done when a PR already closed in GitHub is not reported as open after the layer is deleted.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
github, go
Área
api, cli
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Activo
Claridad
Bastante claro
Aptitud para principiantes
65/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.