github / github/gh-stack

gh stack sync reports success after its atomic push fails

未關閉
#417 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
bug topic: cli - sync
主要語言
Go
星號
1.5k
分支
70
平均合併
1 天 8 小時
30 天內合併 PR
7

描述

## Reproduction

Start with an existing three-PR stack whose local branches were rebased and therefore require force pushes, then run:

```console
$ gh stack sync --remote origin
✓ Fetched latest dev from origin
✓ Trunk dev is already up to date

Pushing 3 branches to origin...
⚠ Push failed — branches may need force push after rebase
Run `gh stack push` to push with --force-with-lease.

Syncing PRs ...
✓ PR #4440 (...) — Open
✓ PR #4441 (...) — Open
✓ PR #4444 (...) — Open
⚠ Cannot create stack: Pull requests must form a stack, where each PR's base ref is the previous PR's head ref
Each PR's base branch must match the previous PR's head branch.

✓ Branches synced
Stacked on dev (a80f5ad)

$ echo $?
0
```

All three remote branch SHAs remained unchanged. The local stack was therefore not published, but `sync` continued into PR synchronization, printed a success receipt, and exited zero.

## Expected

`gh stack sync` exits nonzero immediately when its atomic branch push fails. It does not attempt PR synchronization or print `Branches synced`, because the remote stack cannot match local state until the branch refs are updated.

## Environment

- `gh-stack` v0.1.0
- `gh` 2.96.0
- git 2.50.1
- macOS arm64

## Related

#346 covers suppressed git-hook output during `gh stack push`. This report is about `sync` swallowing the failed-push status and returning a false success.

貢獻指南

開啟貢獻指南

研究方向

Start at the `gh stack sync` command and trace the atomic branch push result. Verify that a failed push stops PR synchronization, avoids the `Branches synced` receipt, and returns nonzero; add or update coverage for the reproduced three-PR rebase case.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
git, github, go
領域
cli
Issue 類型
缺陷
難度
3/5
預估耗時
1-2 天
活躍度
冷清
描述清晰度
描述清楚
新手友好度
70/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。