gh stack sync reports success after its atomic push fails
- 主要语言
- Go
- 星标
- 1.5k
- 派生
- 70
- 平均合并
- 1 天 8 小时
- 30 天内合并 PR
- 7
描述
## Reproduction
Start with an existing three-PR stack whose local branches were rebased and therefore require force pushes, then run:
```console
$ gh stack sync --remote origin
✓ Fetched latest dev from origin
✓ Trunk dev is already up to date
Pushing 3 branches to origin...
⚠ Push failed — branches may need force push after rebase
Run `gh stack push` to push with --force-with-lease.
Syncing PRs ...
✓ PR #4440 (...) — Open
✓ PR #4441 (...) — Open
✓ PR #4444 (...) — Open
⚠ Cannot create stack: Pull requests must form a stack, where each PR's base ref is the previous PR's head ref
Each PR's base branch must match the previous PR's head branch.
✓ Branches synced
Stacked on dev (a80f5ad)
$ echo $?
0
```
All three remote branch SHAs remained unchanged. The local stack was therefore not published, but `sync` continued into PR synchronization, printed a success receipt, and exited zero.
## Expected
`gh stack sync` exits nonzero immediately when its atomic branch push fails. It does not attempt PR synchronization or print `Branches synced`, because the remote stack cannot match local state until the branch refs are updated.
## Environment
- `gh-stack` v0.1.0
- `gh` 2.96.0
- git 2.50.1
- macOS arm64
## Related
#346 covers suppressed git-hook output during `gh stack push`. This report is about `sync` swallowing the failed-push status and returning a false success.
贡献指南
调研方向
从 `gh stack sync` 命令开始,跟踪原子分支推送结果。验证失败的推送会停止 PR 同步、不会产生 `Branches synced` 回执,并返回非零值;为复现的三个 PR rebase 场景添加或更新测试覆盖率。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- git, github, go
- 领域
- cli
- Issue 类型
- 缺陷
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 活跃度
- 冷清
- 描述清晰度
- 描述清楚
- 新手友好度
- 70/100