github / github/gh-stack

link doesn't recognize a branch's existing merged/closed PR, tries to create a duplicate

Abierto
#373 0 comentarios 1 reacción 0 asignados Ver en GitHub
bug topic: cli - link
Lenguaje dominante
Go
Estrellas
1.5k
Forks
70
Merge medio
1 d 8 h
PR fusionados (30 d)
7

Descripción

## Summary

`gh stack link` looks up an existing PR for each branch argument, but the lookup appears scoped to **open** PRs only. For a branch whose PR already merged or was closed (unmerged), `link` reports no PR found and attempts to **create a new one** — contradicting the documented additive-only design ("existing PRs are never removed").

## Repro

1. Build a stack `main <- a <- b <- c <- d <- e` via `gh stack link`.
2. Merge `a` and `b`. Close `c` without merging (its content landed elsewhere, or it was abandoned).
3. Later, run `gh stack link` again with the full historical branch list (e.g. to fix `d`'s base after `c` closed):
`gh stack link a b c d e --base main`

## Actual

```
Checking existing stacks...
Pushing N branches to origin...
Looking up PRs for 5 branches...
Found PR #.. for branch d
Found PR #.. for branch e
Creating 3 PRs...
✗ failed to create PR for branch a: creating PR: GraphQL: was submitted too quickly, Head sha can't be blank, Base sha can't be blank, No commits between main and a, Head ref must be a branch (createPullRequest)
```

Only the still-open branches (`d`, `e`) were recognized as "Found PR". The merged branch `a` (whose content is already in `main`, hence "No commits between main and a") and the closed branch `c` were both treated as PR-less and queued for creation.

In my case the create call failed immediately on the first attempt (an already-merged branch has no diff vs. its base, so `createPullRequest` rejects it), so no duplicate PR was actually created — I confirmed this via `gh pr list --head --state all` for each affected branch afterward. But this looks like it depends on the specific branch/repo state; a branch that still has *some* diff against the base (e.g. a closed-but-unmerged PR whose branch wasn't cleaned up) would likely succeed in creating a genuine duplicate PR.

## Expected

`link`'s PR lookup should match a branch's PR regardless of state (open, closed, or merged) before deciding whether to create a new one, consistent with the "existing PRs are never removed" behavior documented for this command.

## Environment

`gh-stack` version 0.0.8, installed via `gh extension install github/gh-stack`.

Related: #372 (same investigation session, different symptom of the same overall stack-mutation scenario — see also the atomicity issue I'm filing separately).

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Comienza en el punto de entrada `gh stack link` y sigue la búsqueda de PR existentes antes de que se llame a `createPullRequest`. Reproduce el problema con ramas fusionadas y cerradas, y compáralo después con `gh pr list --head --state all`. Se considera terminado cuando se reconocen los PR existentes en cualquier estado y no se intenta crear ninguno duplicado.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
github, go
Área
api, cli
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Tranquilo
Claridad
Bastante claro
Aptitud para principiantes
66/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.