github / github/gh-stack

unstack shows a generic/incorrect error instead of the real API rejection reason

Đang mở
#372 1 bình luận 0 reaction 0 người được giao Xem trên GitHub
bug topic: stack management
Ngôn ngữ chính
Go
Star
1.5k
Fork
70
Merge trung bình
1 ngày 8 giờ
Pull request đã merge (30 ngày)
7

Mô tả

## Summary

`gh stack unstack ` fails on a stack containing merged PRs, but the plain (non-debug) error message names an unrelated cause. The actual server-side reason is only visible with `GH_DEBUG=api`.

## Repro

1. Create a stack with `gh stack link` (or `submit`), e.g. `main <- a <- b <- c <- d <- e`.
2. Merge `a` and `b` (via merge queue or a normal merge — doesn't matter which).
3. Run `gh stack unstack ` on that stack.

## Actual

```
⚠ Some pull requests are queued for merge or have auto-merge enabled and remain stacked on GitHub
The stack was left in place — local tracking is unchanged
```

I verified via `gh api graphql` that **none** of the stack's PRs had `autoMergeRequest` set or a `mergeQueueEntry` — so the stated reason doesn't match reality.

Running the identical command with `GH_DEBUG=api gh stack unstack ` shows the real HTTP exchange:

```
POST /repos/{owner}/{repo}/stacks/{id}/unstack
< HTTP/2.0 422 Unprocessable Entity
{
"message": "Pull requests #.. , #.. cannot be removed from this stack",
"documentation_url": "https://docs.github.com/rest/pulls/stacks#remove-pull-requests-from-a-pull-request-stack",
"status": "422"
}
```

Interestingly, in the `GH_DEBUG=api` run the CLI's own final stderr line correctly echoed this specific message (`✗ Unstacking not allowed: Pull requests #.., #.. cannot be removed from this stack`) — a materially different, and accurate, explanation compared to the generic message shown without debug logging.

## Expected

The non-debug error message should reflect the actual REST API rejection (a stack can't be unstacked once any of its PRs have merged), not a generic, unrelated "queued for merge / auto-merge enabled" message.

## Environment

`gh-stack` version 0.0.8, installed via `gh extension install github/gh-stack`.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Hướng nghiên cứu

Start by reproducing `gh stack unstack ` on a stack with merged pull requests, comparing normal output with `GH_DEBUG=api`. Trace the unstack error handling and the REST API's 422 response; done means the non-debug output reports the actual rejection reason rather than the unrelated queued-for-merge message.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Đánh giá

Công nghệ
github, go
Lĩnh vực
api, cli
Loại issue
Lỗi
Độ khó
3/5
Thời gian dự kiến
1-2 ngày
Mức độ hoạt động
Sôi nổi
Độ rõ ràng
Khá rõ ràng
Mức phù hợp với người mới
67/100

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.