github / github/gh-stack

`gh stack sync` always rebases, which breaks PR review history

Ouverte
#354 7 commentaires 29 réactions 0 personnes assignées Voir sur GitHub
feature request topic: rebase alternative
Langage dominant
Go
Étoiles
1.5k
Forks
70
Merge moyen
1 j 8 h
PR mergées (30 j)
7

Description

If a reviewer has already viewed/reviewed a PR, and the submitter performs a `gh stack sync`, it will then force-push, which erases useful information about "changes since last view" in the PR interface.

It should be an option (the default?) to perform a merge from upstream rather than a rebase to avoid messing up the review history.

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Start at the implementation and tests for `gh stack sync`; reproduce a sync where upstream changes exist and compare the current rebase behavior with a merge. Done means the command supports the requested non-rewriting behavior, with its option or default settled and tests covering the resulting history.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
git, github, go
Domaine
cli, developer-experience
Type d'issue
Fonctionnalité
Difficulté
3/5
Temps estimé
1-2 jours
Activité
Active
Clarté
Plutôt claire
Accessibilité débutants
58/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.