`gh stack sync` always rebases, which breaks PR review history
Offen
feature request
topic: rebase alternative
- Vorherrschende Sprache
- Go
- Sterne
- 1.5k
- Forks
- 70
- Ø Merge
- 1 T. 8 Std.
- Gemergte PRs (30 T.)
- 7
Beschreibung
If a reviewer has already viewed/reviewed a PR, and the submitter performs a `gh stack sync`, it will then force-push, which erases useful information about "changes since last view" in the PR interface.
It should be an option (the default?) to perform a merge from upstream rather than a rebase to avoid messing up the review history.
Beitragsleitfaden
Rechercherichtung
Start at the implementation and tests for `gh stack sync`; reproduce a sync where upstream changes exist and compare the current rebase behavior with a merge. Done means the command supports the requested non-rewriting behavior, with its option or default settled and tests covering the resulting history.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- git, github, go
- Bereich
- cli, developer-experience
- Issue-Typ
- Feature
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Aktivitätsstatus
- Aktiv
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 58/100