github / github/gh-stack

`gh stack sync` always rebases, which breaks PR review history

Open
#354 7 comments 29 reactions 0 assignees View on GitHub
feature request topic: rebase alternative
Dominant language
Go
Stars
1.5k
Forks
70
Avg merge
1d 8h
Merged PRs (30d)
7

Description

If a reviewer has already viewed/reviewed a PR, and the submitter performs a `gh stack sync`, it will then force-push, which erases useful information about "changes since last view" in the PR interface.

It should be an option (the default?) to perform a merge from upstream rather than a rebase to avoid messing up the review history.

Contributor guide

Open the contributing guide

Research direction

Start at the implementation and tests for `gh stack sync`; reproduce a sync where upstream changes exist and compare the current rebase behavior with a merge. Done means the command supports the requested non-rewriting behavior, with its option or default settled and tests covering the resulting history.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, github, go
Domain
cli, developer-experience
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.