github / github/gh-stack

`gh stack sync` should tell you what branches it wants to prune on your behalf

Aperta
#162 1 commento 1 reazione 0 assegnatari Vedi su GitHub
feature request topic: cli - sync
Lingua principale
Go
Stelle
1.5k
Fork
70
Merge medio
1g 8h
PR unite (30g)
7

Descrizione

Here's a state where I just used `gh stack sync` after manually merging PR 2 in a stack of 7 PRs.

Image

Everything looks good, except `Prune 1 merged branch` is a bit unclear.

I've already run `gh stack sync` after merging PR 1 too, so the branch for PR 1, `feature/sources-1-oak-cache` is already gone.

So the 1 branch to prune must be referring to `feature/sources-2-oak-source`, which makes sense, but it requires me to kind of interpret between the lines here.

It would be a bit more obvious (and safer?) if `Prune 1 merged branch` just listed the names of the branches it wants to prune somewhere. You see them after you say `Y`, but that's a bit too late 😬

Image

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start by tracing the `gh stack sync` command's prune confirmation output and the code that lists merged branches. Update the pre-confirmation message so it names each branch that will be pruned, then verify that the names shown before confirmation match the branches removed after approval.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
go
Ambito
cli
Tipo di issue
Funzionalità
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Tranquilla
Chiarezza
Abbastanza chiara
Idoneità per principianti
68/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.