github / github/gh-stack

`gh stack sync` should tell you what branches it wants to prune on your behalf

Offen
#162 1 Kommentar 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen
feature request topic: cli - sync
Vorherrschende Sprache
Go
Sterne
1.5k
Forks
70
Ø Merge
1 T. 8 Std.
Gemergte PRs (30 T.)
7

Beschreibung

Here's a state where I just used `gh stack sync` after manually merging PR 2 in a stack of 7 PRs.

Image

Everything looks good, except `Prune 1 merged branch` is a bit unclear.

I've already run `gh stack sync` after merging PR 1 too, so the branch for PR 1, `feature/sources-1-oak-cache` is already gone.

So the 1 branch to prune must be referring to `feature/sources-2-oak-source`, which makes sense, but it requires me to kind of interpret between the lines here.

It would be a bit more obvious (and safer?) if `Prune 1 merged branch` just listed the names of the branches it wants to prune somewhere. You see them after you say `Y`, but that's a bit too late 😬

Image

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start by tracing the `gh stack sync` command's prune confirmation output and the code that lists merged branches. Update the pre-confirmation message so it names each branch that will be pruned, then verify that the names shown before confirmation match the branches removed after approval.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
go
Bereich
cli
Issue-Typ
Feature
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Ruhig
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
68/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.