github / github/eslint-plugin-github

Usage of `title` via prop drilling not detected

未關閉
#467 15 則留言 1 個 reaction 已指派 1 人 已被 @kendallgassner 認領 在 GitHub 檢視
主要語言
JavaScript
星號
336
分支
67
平均合併
1 天 9 小時
30 天內合併 PR
6

描述

Recently found a couple of cases of `title` attribute usage (soon to be addressed in https://github.com/github/issues/issues/7066 🙏) that are not detected by the rule.

This seems to be the case when prop drilling `title` into a component, unsure if because this specific scenario is overriding the type prop or something else.

[Root usage of the attribute](https://github.com/github/github/blob/3e4881e7aab7d0473ed9c1b89a3712a9e1d65f3b/ui/packages/issue-viewer/components/sections/RelationsSection.tsx#L84)
[Props object with the `title` prop being spread into a button](https://github.com/github/github/blob/3e4881e7aab7d0473ed9c1b89a3712a9e1d65f3b/ui/packages/issue-viewer/components/sections/SectionHeader.tsx#L48)
[Prop type overriding `title`](https://github.com/github/github/blob/3e4881e7aab7d0473ed9c1b89a3712a9e1d65f3b/ui/packages/issue-viewer/components/sections/SectionHeader.tsx#L12)

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。