github / github/eslint-plugin-github

Usage of `title` via prop drilling not detected

Ouverte
#467 15 commentaires 1 réaction 1 personne assignée Réclamée par @kendallgassner Voir sur GitHub
Langage dominant
JavaScript
Étoiles
336
Forks
67
Merge moyen
1 j 9 h
PR mergées (30 j)
6

Description

Recently found a couple of cases of `title` attribute usage (soon to be addressed in https://github.com/github/issues/issues/7066 🙏) that are not detected by the rule.

This seems to be the case when prop drilling `title` into a component, unsure if because this specific scenario is overriding the type prop or something else.

[Root usage of the attribute](https://github.com/github/github/blob/3e4881e7aab7d0473ed9c1b89a3712a9e1d65f3b/ui/packages/issue-viewer/components/sections/RelationsSection.tsx#L84)
[Props object with the `title` prop being spread into a button](https://github.com/github/github/blob/3e4881e7aab7d0473ed9c1b89a3712a9e1d65f3b/ui/packages/issue-viewer/components/sections/SectionHeader.tsx#L48)
[Prop type overriding `title`](https://github.com/github/github/blob/3e4881e7aab7d0473ed9c1b89a3712a9e1d65f3b/ui/packages/issue-viewer/components/sections/SectionHeader.tsx#L12)

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.