github / github/eslint-plugin-github

Usage of `title` via prop drilling not detected

Open
#467 15 comments 1 reaction 1 assignee Claimed by @kendallgassner View on GitHub
Dominant language
JavaScript
Stars
336
Forks
67
Avg merge
1d 9h
Merged PRs (30d)
6

Description

Recently found a couple of cases of `title` attribute usage (soon to be addressed in https://github.com/github/issues/issues/7066 🙏) that are not detected by the rule.

This seems to be the case when prop drilling `title` into a component, unsure if because this specific scenario is overriding the type prop or something else.

[Root usage of the attribute](https://github.com/github/github/blob/3e4881e7aab7d0473ed9c1b89a3712a9e1d65f3b/ui/packages/issue-viewer/components/sections/RelationsSection.tsx#L84)
[Props object with the `title` prop being spread into a button](https://github.com/github/github/blob/3e4881e7aab7d0473ed9c1b89a3712a9e1d65f3b/ui/packages/issue-viewer/components/sections/SectionHeader.tsx#L48)
[Prop type overriding `title`](https://github.com/github/github/blob/3e4881e7aab7d0473ed9c1b89a3712a9e1d65f3b/ui/packages/issue-viewer/components/sections/SectionHeader.tsx#L12)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.