github / github/eslint-plugin-github

Request: Add typescript support

Aberta
#406 1 comentário 1 reação 0 responsáveis Ver no GitHub
Linguagem predominante
JavaScript
Estrelas
336
Forks
67
Merge médio
1d 9h
PRs com merge (30d)
6

Descrição

I'm working on an addition to [insights-web](https://github.com/github/insights-web) ([PR](https://github.com/github/insights-web/pull/123)) that requires an upgrade to Chart.js 4. Chart.js 4 added typescript `.d.ts` definitions for various exported types. This breaks the GitHub eslint rules because the linter isn't able to resolve the imported types, despite everything compiling correctly. I was able to fix the linting by adding and configuring [eslint-import-resolver-typescript](https://www.npmjs.com/package/eslint-import-resolver-typescript) to the project. I wanted to submit this issue here though because this seems like a better addition to `estlint-plugin-github`, that way we have org-wide TS linting support. There's also an alternative [eslint-plugin-i](https://github.com/un-es/eslint-plugin-i) package that claims to be faster than `eslint-plugin-import`.

Guia de contribuição

Abrir o guia de contribuição

Direção de pesquisa

Review eslint-plugin-github's current dependency and resolver configuration, then compare the proposed eslint-import-resolver-typescript approach with the alternative eslint-plugin-i package. Done means TypeScript .d.ts imports resolve correctly under the plugin's ESLint rules and the existing lint checks pass.

Escrita pelo modelo de indexação a partir do texto da issue.

Avaliação

Stack de tecnologia
javascript, typescript
Domínio
tooling
Tipo de issue
Funcionalidade
Dificuldade
4/5
Tempo estimado
3-5 dias
Status de atividade
Estagnada
Clareza
Razoavelmente clara
Facilidade para iniciantes
35/100

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.