github / github/eslint-plugin-github

Request: Add typescript support

Aperta
#406 1 commento 1 reazione 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
336
Fork
67
Merge medio
1g 9h
PR unite (30g)
6

Descrizione

I'm working on an addition to [insights-web](https://github.com/github/insights-web) ([PR](https://github.com/github/insights-web/pull/123)) that requires an upgrade to Chart.js 4. Chart.js 4 added typescript `.d.ts` definitions for various exported types. This breaks the GitHub eslint rules because the linter isn't able to resolve the imported types, despite everything compiling correctly. I was able to fix the linting by adding and configuring [eslint-import-resolver-typescript](https://www.npmjs.com/package/eslint-import-resolver-typescript) to the project. I wanted to submit this issue here though because this seems like a better addition to `estlint-plugin-github`, that way we have org-wide TS linting support. There's also an alternative [eslint-plugin-i](https://github.com/un-es/eslint-plugin-i) package that claims to be faster than `eslint-plugin-import`.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Review eslint-plugin-github's current dependency and resolver configuration, then compare the proposed eslint-import-resolver-typescript approach with the alternative eslint-plugin-i package. Done means TypeScript .d.ts imports resolve correctly under the plugin's ESLint rules and the existing lint checks pass.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
javascript, typescript
Ambito
tooling
Tipo di issue
Funzionalità
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.