github / github/copilot-cli

Cloud coding agent opens empty PR when invoked from a fork-backed PR review comment

Abierto
#4,559 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

triage
Lenguaje dominante
Shell
Estrellas
11.2k
Forks
1.9k
Merge medio
14 h 16 min
PR fusionados (30 d)
6

Descripción

Describe the bug

Product

GitHub Copilot cloud coding agent (app/copilot-swe-agent), triggered from review feedback on a fork-backed pull request. This may need routing to the hosted coding-agent workflow owners.

Summary

When Copilot was started from a review comment on a fork-backed pull request, it created a draft PR from upstream main instead of the reviewed PR’s fork head. The requested file existed only in the reviewed PR, so the agent could not change it. It nevertheless opened an empty draft PR with an empty Initial plan commit.

Reproduction

  1. Open a PR from a personal fork to an upstream repository.
  2. Add review feedback about a file introduced by that PR and absent from upstream main.
  3. Start Copilot coding agent from that review comment.
  4. Copilot creates its branch from upstream main rather than the reviewed PR head.

Actual behavior

  • Reviewed PR: https://github.com/microsoft/rushstack/pull/5949
  • Empty Copilot PR: https://github.com/microsoft/rushstack/pull/5951
  • Copilot branch: microsoft:copilot/fix-review-comment-5949
  • Base SHA: d563d6a09ebef0be1ff274faf8c1008767166875
  • Head SHA: 7c5a2f29b89b8a8e59da5521ececbb918bd3f5e5
  • Result: 0 changed files, 0 additions, 0 deletions.
  • The head commit is titled Initial plan and is provably empty: both the head and parent tree SHA are 65487a74d0cb345023b9aebe08aa233d79e1097d.
  • The timeline records copilot_work_started and copilot_work_finished despite producing no change.

The reviewed file, libraries/rush-daemon/src/test/WorkspaceEngineComponentFactory.test.ts, existed only on PR #5949’s fork head and not on upstream main.

Expected behavior

For review-comment tasks on fork-backed PRs, Copilot should either:

  1. Base its work on the reviewed PR’s exact head; or
  2. Stop before creating a PR and report that fork-head access is unsupported.

Copilot should never publish a zero-diff PR when its head and base trees are identical.

Suggested safeguards

  • Preserve the reviewed PR head SHA when launching from inline review feedback.
  • Verify that the referenced file and line exist in the selected base.
  • Compare head and base trees before publishing; suppress an identical-tree PR.
  • Report an explicit unsupported-fork error instead of silently falling back to upstream main.
Affected version

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

Additional context

No response

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza comparando el fork head de PR #5949 con upstream main, especialmente libraries/rush-daemon/src/test/WorkspaceEngineComponentFactory.test.ts, e inspecciona el PR vacío #5951 y su commit Initial plan. Sigue la ruta de lanzamiento desde los comentarios de revisión para los PR basados en forks en el hosted coding-agent workflow. Se considera completado cuando se conserva o se rechaza explícitamente el fork head y se evita la publicación de cualquier PR con un tree idéntico.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
github
Área
cloud, devtools
Tipo de issue
Error
Dificultad
5/5
Tiempo estimado
Más de una semana
Estado de actividad
Activo
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.