github / github/copilot-cli

Cloud coding agent opens empty PR when invoked from a fork-backed PR review comment

Offen
#4,559 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

triage
Vorherrschende Sprache
Shell
Sterne
11.2k
Forks
1.9k
Ø Merge
14 Std. 16 Min.
Gemergte PRs (30 T.)
6

Beschreibung

Describe the bug

Product

GitHub Copilot cloud coding agent (app/copilot-swe-agent), triggered from review feedback on a fork-backed pull request. This may need routing to the hosted coding-agent workflow owners.

Summary

When Copilot was started from a review comment on a fork-backed pull request, it created a draft PR from upstream main instead of the reviewed PR’s fork head. The requested file existed only in the reviewed PR, so the agent could not change it. It nevertheless opened an empty draft PR with an empty Initial plan commit.

Reproduction

  1. Open a PR from a personal fork to an upstream repository.
  2. Add review feedback about a file introduced by that PR and absent from upstream main.
  3. Start Copilot coding agent from that review comment.
  4. Copilot creates its branch from upstream main rather than the reviewed PR head.

Actual behavior

  • Reviewed PR: https://github.com/microsoft/rushstack/pull/5949
  • Empty Copilot PR: https://github.com/microsoft/rushstack/pull/5951
  • Copilot branch: microsoft:copilot/fix-review-comment-5949
  • Base SHA: d563d6a09ebef0be1ff274faf8c1008767166875
  • Head SHA: 7c5a2f29b89b8a8e59da5521ececbb918bd3f5e5
  • Result: 0 changed files, 0 additions, 0 deletions.
  • The head commit is titled Initial plan and is provably empty: both the head and parent tree SHA are 65487a74d0cb345023b9aebe08aa233d79e1097d.
  • The timeline records copilot_work_started and copilot_work_finished despite producing no change.

The reviewed file, libraries/rush-daemon/src/test/WorkspaceEngineComponentFactory.test.ts, existed only on PR #5949’s fork head and not on upstream main.

Expected behavior

For review-comment tasks on fork-backed PRs, Copilot should either:

  1. Base its work on the reviewed PR’s exact head; or
  2. Stop before creating a PR and report that fork-head access is unsupported.

Copilot should never publish a zero-diff PR when its head and base trees are identical.

Suggested safeguards

  • Preserve the reviewed PR head SHA when launching from inline review feedback.
  • Verify that the referenced file and line exist in the selected base.
  • Compare head and base trees before publishing; suppress an identical-tree PR.
  • Report an explicit unsupported-fork error instead of silently falling back to upstream main.
Affected version

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

Additional context

No response

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Rechercherichtung

Beginne damit, den Fork-Head von PR #5949 mit upstream main zu vergleichen, insbesondere libraries/rush-daemon/src/test/WorkspaceEngineComponentFactory.test.ts, und untersuche den leeren PR #5951 sowie dessen Initial plan-Commit. Verfolge den Pfad zum Starten aus Review-Kommentaren für Fork-basierte PRs im gehosteten coding-agent-Workflow. Als abgeschlossen gilt die Aufgabe, wenn der Fork-Head beibehalten oder ausdrücklich abgelehnt wird und die Veröffentlichung eines PRs mit identischem Tree verhindert wird.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
github
Bereich
cloud, devtools
Issue-Typ
Bug
Schwierigkeit
5/5
Geschätzter Aufwand
Über eine Woche
Aktivitätsstatus
Aktiv
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
35/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.