Constrain `run_factory` to registered factory names to prevent repeated guesses
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 11.2k
- Forks
- 1.9k
- Avg merge
- 14h 16m
- Merged PRs (30d)
- 6
Description
Summary
run_factory can be exposed with an unconstrained name argument even when no matching factory is registered. The model can interpret tool availability as factory availability, invent plausible names, and retry them serially.
Originally reported from the VS Code Agents Window in microsoft/vscode#329551.
Observed behavior
With Copilot CLI 1.0.78 and GPT-5.6 Sol, one session produced 13 distinct model-authored run_factory calls. Every call failed immediately with:
RpcResponseError: No factory registered with name "<name>"
The model first tried eight implementation-oriented names:
apply_findingcode_implementation_factorysingle_taskimplementationcode-taskfix-factoryrepo_taskreview_then_implement
It later tried five more names for video analysis:
video_analysisanalyze_videosingle_video_analysisvideo-analysismedia_analysis
These were separate assistant-authored calls after each rejection, not host retries. No factory ran.
Steps to reproduce
- Expose
run_factoryin a session where no matching factories are registered. - Ask the agent to perform a routine single-session task, such as a small implementation or media-analysis task.
- Observe that the model may invent and repeatedly retry factory names.
Expected behavior
Invalid factory names should be impossible or strongly bounded. Ideally:
- Dynamically constrain
nameto registered factory names. - Do not expose
run_factorywhen there are no registered factories or resumable runs. - If dynamic enum generation is not possible, require registry discovery before invocation and include available names in validation errors.
- Enforce exactly one of
nameandresumeFromRunIdat the schema level.
Actual behavior
name is effectively a free-form string, so failures occur only after a costly tool round trip. Prompt guidance to use factories selectively did not prevent repeated guesses.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the run_factory tool schema, factory registry, and validation path in the repository. Trace how registered names and resumable runs are exposed, then identify existing tests for tool invocation or schema validation; done means invalid names are bounded before a tool round trip and name/resumeFromRunId exclusivity is enforced.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100