github / github/copilot-cli

`agentStop` triggering on subagent turns causing `/review` to never finish/return

Abierto
#3,894 1 comentario 1 reacción 0 asignados Ver en GitHub
area:agents area:plugins
Lenguaje dominante
Shell
Estrellas
11.2k
Forks
1.9k
Merge medio
14 h 16 min
PR fusionados (30 d)
6

Descripción

### Describe the bug

I have a custom hook registered to `agentStop` that instructs the agent to improve instructions files based on the work it did and issues it ran into (if instructions were out-of-date) [digivolution](https://github.com/scaryrawr/scarypilot/tree/main/plugins/digivolution).

This is intended to only be ran by the main agent, which [hook events](https://docs.github.com/en/copilot/reference/hooks-reference#hook-events) mentions the `agentStop` fires when:
> The main agent finishes a turn.

When running subagents lately, I see that `/review` never succeeds because the subagent is running main agent stop hooks:

![Image](https://github.com/user-attachments/assets/480bc829-0f9b-40c6-a2e9-e408b59a984f)

![Image](https://github.com/user-attachments/assets/b43664c2-dd3e-4e07-9090-8f79ba8bdd67)

Since the stop hook can trigger the agent to keep working, it ends up the subagent never submits the review response, even though it finished the stop hook condition as well.

### Affected version

GitHub Copilot CLI 1.0.64-3

### Steps to reproduce the behavior

1. Register a `stopAgent` hook that can block the agent turn from ending
2. Do a `/review` in a codebase where it uses subagents

### Expected behavior

The subagent should not run the `stopAgent` hook since there is a separate `subagentStop` hook and `stopAgent` is documented as not being used for subagents.

The actual behavior is that `stopAgent` is also picked up by subagents and ran.

### Additional context

_No response_

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Start by reproducing `/review` with a blocking `stopAgent` hook on GitHub Copilot CLI 1.0.64-3, then compare the documented `agentStop` and separate `subagentStop` behavior. Trace hook handling during subagent turns; done means subagents no longer run `stopAgent`, while the main agent still does and `/review` returns.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
github, shell
Área
cli, tooling
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Activo
Claridad
Bastante claro
Aptitud para principiantes
68/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.