`agentStop` triggering on subagent turns causing `/review` to never finish/return
- Vorherrschende Sprache
- Shell
- Sterne
- 11.2k
- Forks
- 1.9k
- Ø Merge
- 14 Std. 16 Min.
- Gemergte PRs (30 T.)
- 6
Beschreibung
### Describe the bug
I have a custom hook registered to `agentStop` that instructs the agent to improve instructions files based on the work it did and issues it ran into (if instructions were out-of-date) [digivolution](https://github.com/scaryrawr/scarypilot/tree/main/plugins/digivolution).
This is intended to only be ran by the main agent, which [hook events](https://docs.github.com/en/copilot/reference/hooks-reference#hook-events) mentions the `agentStop` fires when:
> The main agent finishes a turn.
When running subagents lately, I see that `/review` never succeeds because the subagent is running main agent stop hooks:


Since the stop hook can trigger the agent to keep working, it ends up the subagent never submits the review response, even though it finished the stop hook condition as well.
### Affected version
GitHub Copilot CLI 1.0.64-3
### Steps to reproduce the behavior
1. Register a `stopAgent` hook that can block the agent turn from ending
2. Do a `/review` in a codebase where it uses subagents
### Expected behavior
The subagent should not run the `stopAgent` hook since there is a separate `subagentStop` hook and `stopAgent` is documented as not being used for subagents.
The actual behavior is that `stopAgent` is also picked up by subagents and ran.
### Additional context
_No response_
Beitragsleitfaden
Rechercherichtung
Start by reproducing `/review` with a blocking `stopAgent` hook on GitHub Copilot CLI 1.0.64-3, then compare the documented `agentStop` and separate `subagentStop` behavior. Trace hook handling during subagent turns; done means subagents no longer run `stopAgent`, while the main agent still does and `/review` returns.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- github, shell
- Bereich
- cli, tooling
- Issue-Typ
- Bug
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Aktivitätsstatus
- Aktiv
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 68/100