Stale inuse.<pid>.lock files left behind on unclean exit (SIGKILL / crashes)
- 主要言語
- Shell
- スター
- 11.2k
- フォーク
- 1.9k
- 平均マージ
- 14時間 16分
- マージ済み PR(30日)
- 6
説明
## Summary
The agency CLI / Copilot CLI does not reliably unlink its `inuse..lock` file on every exit path. When the process is sent SIGKILL, crashes, or exits via certain unclean paths, stale lock files accumulate in `~/.copilot/session-state//`. Future attempts to resume the affected sessions then incorrectly believe the session is still in use.
## Symptom (downstream)
We hit this in [copilot-ide](https://github.com/shachaf-ashkenazi/copilot-ide), an Electron wrapper around `agency copilot --acp` / `agency copilot`. After any unclean exit, opening an old session shows a "Force resume?" prompt because the IDE sees a leftover `inuse..lock` and (correctly) refuses to overwrite a session that *might* still be open elsewhere.
User-visible bug we filed downstream: shachaf-ashkenazi/copilot-ide#18.
Reproduction is trivial: start a session (`agency copilot &`), then SIGKILL the resulting PID (signal 9). The `inuse..lock` file in the session dir survives the dead process indefinitely.
## Current downstream workaround
We do PID-liveness probing in the IDE before trusting any lock file:
[`src/main/sessionLocks.ts`](https://github.com/shachaf-ashkenazi/copilot-ide/blob/master/src/main/sessionLocks.ts).
It parses the PID out of the filename, calls `process.kill(pid, 0)` (POSIX no-op probe) to check if it's alive, then runs `ps -p -o command=` to verify the live PID actually looks like the Copilot CLI (kernel reuses PIDs aggressively — a multi-day-old lock will frequently point at an unrelated `login` shell or `node` process). Locks owned by dead OR live-but-unrelated PIDs are unlinked.
Empirically: ~5–10 ms per lock probed, only paid when the PID is alive. Catches the bug but is a workaround for behavior the CLI should own.
## Proposed fix (upstream)
Any one of these would close the gap:
1. **Trap `SIGTERM` / `SIGINT` and unlink the lock before exit.** Covers the common "user closes terminal" / IDE-shutdown case. Doesn't help SIGKILL or hard crashes.
2. **Use OS-reclaimed advisory locks (`flock(2)` / `fcntl(F_SETLK)`)** instead of (or in addition to) the on-disk marker file. The kernel releases these when the holding process dies, regardless of how. This is the most robust option.
3. **Bake the PID-liveness reclaim logic into the CLI itself**, the same approach our `sessionLocks.ts` takes. Cheap, no semantic change, defends against pre-existing stale locks created by older versions.
(1) + (3) is probably the easiest path that handles all exit modes. (2) is the cleanest if you're willing to change the lock format.
## Notes
- We'll keep our PID-liveness reclaim in the IDE either way as defense in depth. Removing it would only be safe once we can assume all CLI versions in the wild handle this correctly, which won't be true for years.
- This affects both layouts of the binary that write into `~/.copilot/session-state/`: `~/.copilot-cli//copilot` (the agency-bundled inner binary) and `/opt/homebrew/Caskroom/copilot-cli//copilot` (the standalone Copilot CLI brew Cask). Both need the fix.
## Environment
- agency 2026.5.11.1 (wrapping Copilot CLI 1.0.45)
- macOS (aarch64)
## Related
- Downstream user-visible bug: shachaf-ashkenazi/copilot-ide#18
- Downstream tracker: shachaf-ashkenazi/copilot-ide#37
コントリビューションガイド
調査の方向性
`agency copilot` を起動して SIGKILL を送信し、結果として作成されたセッションディレクトリを調べることで、問題を再現します。upstream の動作と `src/main/sessionLocks.ts` にある downstream の回避策を比較します。CLI のロック実装を特定し、再取得またはクリーンアップの適切な方法を判断します。成功の定義は、サポートされている両方のレイアウトで、クラッシュまたは強制終了の後に古いロックがセッションの再開を妨げなくなることです。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- shell
- 領域
- cli, operating-systems
- issue の種類
- バグ
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 活発さ
- 活発
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 35/100