github / github/codeql

LGTM.com - c++ false positive "Expression has no effect"

未关闭
#5,125 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
C++ false-positive
主要语言
CodeQL
星标
10.1k
派生
2.1k
平均合并
2 天 15 小时
30 天内合并 PR
141

描述

LGTM is reporting a false-positive "Expression has no effect" warning. The expression LGTM is highlighting is this:

```c++
add_global(varName);
```

The definition of `add_global` follows right after the constructor:

```c++
static auto add_global(std::string var) -> bool {
return variables.insert(std::move(var)).second;
}
```

The `variables` variable is a static class variable which is being mutated by this function, which is most definitely an observable side-effect (which is, indeed, observed on parse.yy). There is no other `add_global` function accessible on this point, and no other `variables` variable accessible.

Here is the [link to the alert page](https://lgtm.com/projects/g/flamewing/sorcery-xtractobb/snapshot/eef1e0280b104529e9cd9321ccb4720099e814b7/files/statement.hh?sort=name&dir=ASC&mode=heatmap#x780384747974377a:1).

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。