github / github/codeql

LGTM.com - c++ false positive "Expression has no effect"

Abierto
#5,125 1 comentario 0 reacciones 0 asignados Ver en GitHub
C++ false-positive
Lenguaje dominante
CodeQL
Estrellas
10.1k
Forks
2.1k
Merge medio
2 d 15 h
PR fusionados (30 d)
141

Descripción

LGTM is reporting a false-positive "Expression has no effect" warning. The expression LGTM is highlighting is this:

```c++
add_global(varName);
```

The definition of `add_global` follows right after the constructor:

```c++
static auto add_global(std::string var) -> bool {
return variables.insert(std::move(var)).second;
}
```

The `variables` variable is a static class variable which is being mutated by this function, which is most definitely an observable side-effect (which is, indeed, observed on parse.yy). There is no other `add_global` function accessible on this point, and no other `variables` variable accessible.

Here is the [link to the alert page](https://lgtm.com/projects/g/flamewing/sorcery-xtractobb/snapshot/eef1e0280b104529e9cd9321ccb4720099e814b7/files/statement.hh?sort=name&dir=ASC&mode=heatmap#x780384747974377a:1).

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.