github / github/codeql

LGTM.com - c++ false positive "Expression has no effect"

Open
#5,125 1 comment 0 reactions 0 assignees View on GitHub
C++ false-positive
Dominant language
CodeQL
Stars
10.1k
Forks
2.1k
Avg merge
2d 15h
Merged PRs (30d)
141

Description

LGTM is reporting a false-positive "Expression has no effect" warning. The expression LGTM is highlighting is this:

```c++
add_global(varName);
```

The definition of `add_global` follows right after the constructor:

```c++
static auto add_global(std::string var) -> bool {
return variables.insert(std::move(var)).second;
}
```

The `variables` variable is a static class variable which is being mutated by this function, which is most definitely an observable side-effect (which is, indeed, observed on parse.yy). There is no other `add_global` function accessible on this point, and no other `variables` variable accessible.

Here is the [link to the alert page](https://lgtm.com/projects/g/flamewing/sorcery-xtractobb/snapshot/eef1e0280b104529e9cd9321ccb4720099e814b7/files/statement.hh?sort=name&dir=ASC&mode=heatmap#x780384747974377a:1).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.