LGTM.com - false positive: constant-comparison with assignment on one side
未關閉
C++
false-positive
- 主要語言
- CodeQL
- 星號
- 10.1k
- 分支
- 2.1k
- 平均合併
- 2 天 15 小時
- 30 天內合併 PR
- 141
描述
I have
int next_char;
...
(next_char = gzgetc(file_)) != -1
where gzgetc is from zlib:
ZEXTERN int ZEXPORT gzgetc OF((gzFile file));
It triggers constant-comparison rule with message:
> Comparison is always true because ... = ... >= 0.
In this case (a = b) is integer assignment and can be negative.
https://lgtm.com/projects/g/project-gemmi/gemmi/snapshot/d1a210cf4810719b905806a690feade01e6eb5c9/files/include/gemmi/gz.hpp?sort=name&dir=ASC&mode=heatmap#x4ec8a4d86c53b859:1
貢獻指南
評估
這個 Issue 還沒有評估資料。