LGTM.com - false positive: constant-comparison with assignment on one side
Ouverte
C++
false-positive
- Langage dominant
- CodeQL
- Étoiles
- 10.1k
- Forks
- 2.1k
- Merge moyen
- 2 j 15 h
- PR mergées (30 j)
- 141
Description
I have
int next_char;
...
(next_char = gzgetc(file_)) != -1
where gzgetc is from zlib:
ZEXTERN int ZEXPORT gzgetc OF((gzFile file));
It triggers constant-comparison rule with message:
> Comparison is always true because ... = ... >= 0.
In this case (a = b) is integer assignment and can be negative.
https://lgtm.com/projects/g/project-gemmi/gemmi/snapshot/d1a210cf4810719b905806a690feade01e6eb5c9/files/include/gemmi/gz.hpp?sort=name&dir=ASC&mode=heatmap#x4ec8a4d86c53b859:1
Guide de contribution
Ouvrir le guide de contribution
Évaluation
Cette issue n'a pas encore été évaluée.