github / github/codeql

LGTM.com - false positive C# if `is` followed by `as`

Ouverte
#2,993 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
C# false-positive
Langage dominant
CodeQL
Étoiles
10.1k
Forks
2.1k
Merge moyen
2 j 15 h
PR mergées (30 j)
141

Description

Warning for 'value might be null' because upstream path potentially contains a null. Caused by use of `as` keyword but preceeding `is` keyword should make it impossible.

```csharp
if (value is string)
Validate(fi, dicomFile, dicomItem, value as string); //<- lgtm considers that 'value' could be null because of as
```

https://lgtm.com/projects/g/SMI/SmiServices/snapshot/673082cacc04b4597e96c7461c47096b94d08a45/files/src/microservices/Microservices.IsIdentifiable/Runners/DicomFileRunner.cs?sort=name&dir=ASC&mode=heatmap#x75953d6da49aa143:1

Admittedly the code itself could be better. It should probably use a direct cast instead of `as` or use the declaration feature of C# 7.0 (i.e. `if(value is string s)`)

Unit test:

```csharp
[Test]
public void TestNull()
{
string a = null;

Assert.IsFalse(a is string);
a = "yayy";
Assert.IsTrue(a is string);
}
```

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.