github / github/codeql

LGTM.com - false positive C# if `is` followed by `as`

Abierto
#2,993 1 comentario 0 reacciones 0 asignados Ver en GitHub
C# false-positive
Lenguaje dominante
CodeQL
Estrellas
10.1k
Forks
2.1k
Merge medio
2 d 15 h
PR fusionados (30 d)
141

Descripción

Warning for 'value might be null' because upstream path potentially contains a null. Caused by use of `as` keyword but preceeding `is` keyword should make it impossible.

```csharp
if (value is string)
Validate(fi, dicomFile, dicomItem, value as string); //<- lgtm considers that 'value' could be null because of as
```

https://lgtm.com/projects/g/SMI/SmiServices/snapshot/673082cacc04b4597e96c7461c47096b94d08a45/files/src/microservices/Microservices.IsIdentifiable/Runners/DicomFileRunner.cs?sort=name&dir=ASC&mode=heatmap#x75953d6da49aa143:1

Admittedly the code itself could be better. It should probably use a direct cast instead of `as` or use the declaration feature of C# 7.0 (i.e. `if(value is string s)`)

Unit test:

```csharp
[Test]
public void TestNull()
{
string a = null;

Assert.IsFalse(a is string);
a = "yayy";
Assert.IsTrue(a is string);
}
```

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.