github / github/codeql

False negative in go/email-injection for password reset links built from Forwarded / X-Forwarded-Host

Aperta
#21,770 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
CodeQL
Stelle
10.1k
Fork
2.1k
Merge medio
2g 15h
PR unite (30g)
141

Descrizione

Hi team,

I think I found a false negative in `go/email-injection`.

I ran into this while looking at ZITADEL's `CVE-2025-64101` / `GHSA-mwmh-7px9-4c23`. The vulnerable flow is:

- host data comes from `Forwarded` / `X-Forwarded-Host`
- it is stored in a request/domain context object
- that value is later carried through an event / notification path
- and eventually used to build a password reset link that gets emailed to the user

Very roughly, it looks like this:

```go
hostFromHeader = r.Header.Get(header)

if host == "" {
host = hostFromHeader
}

TriggeredAtOrigin: http.DomainContext(ctx).Origin()

url = login.InitPasswordLink(http_utils.DomainContext(ctx).Origin(), user.ID, code, user.ResourceOwner, authRequestID)
```

The upstream fix sanitizes the host before storing it in the domain context, so this seems like a real missed case, not just a noisy benchmark result.

My guess is that the source side is already covered well enough, since `net/http.Request.Header` is modeled as remote input. The gap seems to be later in the flow, once the value moves through custom structs / event fields / notification helpers before it becomes part of email content.

I think this pattern is fairly common in real Go code. Password reset and verification links are often built indirectly through app-specific context and mailer abstractions, not directly inside a modeled mail API call.

For comparison, Semgrep did flag this codebase, but only with a broader rule about request-derived origin/host usage. It was not precise, but the general idea may still be useful here: request-header-derived host/origin values that later become user-facing links in emails probably deserve better coverage.

A reasonable fix might be improving `go/email-injection` so flow is preserved better through custom carrier objects and “build link first, send email later” patterns.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Parti da go/email-injection e traccia il modo in cui il suo flusso da source a sink gestisce i valori trasferiti attraverso struct personalizzate, campi degli eventi e helper per le notifiche. Confrontalo con il percorso descritto da Forwarded/X-Forwarded-Host a password-reset-link; il lavoro è completo quando la query copre il flusso indiretto ed evita il falso negativo segnalato.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
go
Ambito
security
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Tranquilla
Chiarezza
Abbastanza chiara
Idoneità per principianti
45/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.