github / github/codeql

ShellEscape aint always escaping shells

未关闭
#19,906 4 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
Ruby
主要语言
CodeQL
星标
10.1k
派生
2.1k
平均合并
2 天 15 小时
30 天内合并 PR
141

描述

Hey,

Does not this line mean if a user has defined a dummy function called shellescape() would be considered as a valid sanitizer ?

https://github.com/github/codeql/blob/e02affd327603e89519b67ceffc7e60948831cc1/ruby/ql/lib/codeql/ruby/security/CommandInjectionCustomizations.qll#L53

Thank you

贡献指南

打开贡献指南

调研方向

Start with ruby/ql/lib/codeql/ruby/security/CommandInjectionCustomizations.qll around line 53 and inspect how shellescape() is recognized. Verify whether an arbitrary user-defined function can satisfy the sanitizer check, then determine the intended behavior and how it should be covered. Done means the query no longer treats an unrelated dummy function as valid sanitization.

由索引模型根据 Issue 内容生成。

评估

领域
security
Issue 类型
缺陷
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
需要澄清
新手友好度
32/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。