github / github/codeql

ShellEscape aint always escaping shells

Open
#19,906 4 comments 0 reactions 0 assignees View on GitHub
Ruby
Dominant language
CodeQL
Stars
10.1k
Forks
2.1k
Avg merge
2d 15h
Merged PRs (30d)
141

Description

Hey,

Does not this line mean if a user has defined a dummy function called shellescape() would be considered as a valid sanitizer ?

https://github.com/github/codeql/blob/e02affd327603e89519b67ceffc7e60948831cc1/ruby/ql/lib/codeql/ruby/security/CommandInjectionCustomizations.qll#L53

Thank you

Contributor guide

Open the contributing guide

Research direction

Start with ruby/ql/lib/codeql/ruby/security/CommandInjectionCustomizations.qll around line 53 and inspect how shellescape() is recognized. Verify whether an arbitrary user-defined function can satisfy the sanitizer check, then determine the intended behavior and how it should be covered. Done means the query no longer treats an unrelated dummy function as valid sanitization.

Written by the indexing model from the issue text.

Assessment

Domain
security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.