github / github/codeql

Ruby: ERB parse failure with trailing implicit keyword argument

Đang mở
#16,006 1 bình luận 0 reaction 0 người được giao Xem trên GitHub
acknowledged bug Ruby
Ngôn ngữ chính
CodeQL
Star
10.1k
Fork
2.1k
Merge trung bình
2 ngày 15 giờ
Pull request đã merge (30 ngày)
141

Mô tả

The following example causes a syntax error, but it shouldn't. I think it is due to the way CodeQL interprets ERB. Instead of inserting newlines it may be better for CodeQL to insert explicit semicolons in most cases. There is not really a right way to interpret ERB, because ERB has no specification and there are many ERB interpreters each with their own flavours. We should probably emulate the most often used Rails flavour as closely as possible.

```
<% def foo bar:; end %>
<% bar = 1 %>
<%= foo bar: %>
<% print "hello" %>
```
What's happening is roughly, that the above gets parsed as follows (this is also invalid according to the real Ruby interpreter)
```
def foo bar:; end
bar = 1
foo bar:
print "hello"
```
instead of as (note the extra `;`)
```
def foo bar:; end
bar = 1
foo bar: ;
print "hello"
```

The ERB interpreter of Rails usually inserts `;` symbols between tags, but sometimes it inserts a newline (to make using blocks easier). CodeQL instead always inserts a newline. This difference is hardly ever a problem because Ruby treats newlines as implicit `;` symbols in almost all cases. The trouble is the "almost", there are a few corner cases, and newlines after a keyword argument are one of them.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.