github / github/codeql

cs/unused-collection false positive?

Aperta
#14,073 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
C# false-positive
Lingua principale
CodeQL
Stelle
10.1k
Fork
2.1k
Merge medio
2g 15h
PR unite (30g)
141

Descrizione

Hope this is the right place to file analyzer issues as well, didn't really see any info on recommendations for reporting issues anywhere.

We saw a "Container contents are never accessed" error on our report `cs/unused-collection`: https://github.com/CommunityToolkit/Windows/security/code-scanning/9

Flagging this code in our file:

```cs
private List _overflow = new List();
```

But it was used here in our ArrangeOverride method:

```cs
///
protected override Size ArrangeOverride(Size finalSize)
{
// Have grid to the bulk of our heavy lifting.
var size = base.ArrangeOverride(finalSize);

// Make sure all overflown elements have no size.
foreach (var child in _overflow)
{
child.Arrange(default);
}
```

Is this due to the `foreach` usage or because this is in a framework/platform method that is uncalled by our codebase directly but will be called by the XAML/UWP/WindowsAppSDK platform?

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.