github / github/codeql

cs/unused-collection false positive?

Offen
#14,073 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
C# false-positive
Vorherrschende Sprache
CodeQL
Sterne
10.1k
Forks
2.1k
Ø Merge
2 T. 15 Std.
Gemergte PRs (30 T.)
141

Beschreibung

Hope this is the right place to file analyzer issues as well, didn't really see any info on recommendations for reporting issues anywhere.

We saw a "Container contents are never accessed" error on our report `cs/unused-collection`: https://github.com/CommunityToolkit/Windows/security/code-scanning/9

Flagging this code in our file:

```cs
private List _overflow = new List();
```

But it was used here in our ArrangeOverride method:

```cs
///
protected override Size ArrangeOverride(Size finalSize)
{
// Have grid to the bulk of our heavy lifting.
var size = base.ArrangeOverride(finalSize);

// Make sure all overflown elements have no size.
foreach (var child in _overflow)
{
child.Arrange(default);
}
```

Is this due to the `foreach` usage or because this is in a framework/platform method that is uncalled by our codebase directly but will be called by the XAML/UWP/WindowsAppSDK platform?

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.