github / github/codeql

Document CodeQL `float` `floor()` and `ceil()` behavior for values outside of `int` range

未关闭
#13,063 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
question
主要语言
CodeQL
星标
10.1k
派生
2.1k
平均合并
2 天 15 小时
30 天内合并 PR
141

描述

The documentation for the CodeQL predicates `float.floor()` and `float.ceil()` says:
> Returns the largest integer that is not greater than the receiver

> Returns the smallest integer greater than or equal to the receiver

For both the documentation is incorrect for results outside the `int` value range. The actual behavior of these predicates is that they use the minimum / maximum `int` value if the value exceeds the `int` value range, as seen with this query:
```codeql
from float f
where f = [2200000000.0, -2200000000.0]
select f, f.floor() as floor, f.ceil() as ceil
```

The results are:
| f | floor | ceil |
| -- | -- | -- |
| -2200000000 | -2147483648 | -2147483648
| 2200000000 | 2147483647 | 2147483647

(Tested with CodeQL CLI 2.13.1)

It would be good if the documentation for `floor()` and `ceil()` is adjusted to explicitly mention this.

This might also have to be adjusted in the [QL language specification](https://codeql.github.com/docs/ql-language-reference/ql-language-specification/#built-ins-for-float).

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。