github / github/codeql

Document CodeQL `float` `floor()` and `ceil()` behavior for values outside of `int` range

Open
#13,063 0 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
CodeQL
Stars
10.1k
Forks
2.1k
Avg merge
2d 15h
Merged PRs (30d)
141

Description

The documentation for the CodeQL predicates `float.floor()` and `float.ceil()` says:
> Returns the largest integer that is not greater than the receiver

> Returns the smallest integer greater than or equal to the receiver

For both the documentation is incorrect for results outside the `int` value range. The actual behavior of these predicates is that they use the minimum / maximum `int` value if the value exceeds the `int` value range, as seen with this query:
```codeql
from float f
where f = [2200000000.0, -2200000000.0]
select f, f.floor() as floor, f.ceil() as ceil
```

The results are:
| f | floor | ceil |
| -- | -- | -- |
| -2200000000 | -2147483648 | -2147483648
| 2200000000 | 2147483647 | 2147483647

(Tested with CodeQL CLI 2.13.1)

It would be good if the documentation for `floor()` and `ceil()` is adjusted to explicitly mention this.

This might also have to be adjusted in the [QL language specification](https://codeql.github.com/docs/ql-language-reference/ql-language-specification/#built-ins-for-float).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.