github / github/codeql

A security issue that codeql cannot detect

Ouverte
#12,473 8 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
question
Langage dominant
CodeQL
Étoiles
10.1k
Forks
2.1k
Merge moyen
2 j 15 h
PR mergées (30 j)
141

Description

**A security issue that codeql cannot detect**

A file upload cannot be detected by codeql using the transferTo function
```java
public static File uploadFile(MultipartFile fileUploader) {
if (fileUploader != null && !fileUploader.isEmpty()) {
String fileNameString = fileUploader.getOriginalFilename();
if (!fileNameString.contains(".")) {
throw new RuntimeException("文件后缀获取不到");
} else if (10485760L < fileUploader.getSize()) {
throw new RuntimeException("文件大小不支持大于10M");
} else {
String fileSuffix = fileNameString.substring(fileNameString.lastIndexOf(".") + 1);
String uuid = UUIDUtils.getUuid();
String newFileName = uuid + "." + fileSuffix;
String tmpPath = uploadFilePath + File.separator + newFileName;
File tmpFile = new File(tmpPath);

try {
fileUploader.transferTo(tmpFile);
return tmpFile;
} catch (Exception var8) {
throw new RuntimeException("系统异常:上传失败,请查看日志");
}
}
} else {
throw new RuntimeException("上传文件不能为空");
}
}
```
can you tell me how to solve it

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.