github / github/codeql

A security issue that codeql cannot detect

Abierto
#12,473 8 comentarios 0 reacciones 0 asignados Ver en GitHub
question
Lenguaje dominante
CodeQL
Estrellas
10.1k
Forks
2.1k
Merge medio
2 d 15 h
PR fusionados (30 d)
141

Descripción

**A security issue that codeql cannot detect**

A file upload cannot be detected by codeql using the transferTo function
```java
public static File uploadFile(MultipartFile fileUploader) {
if (fileUploader != null && !fileUploader.isEmpty()) {
String fileNameString = fileUploader.getOriginalFilename();
if (!fileNameString.contains(".")) {
throw new RuntimeException("文件后缀获取不到");
} else if (10485760L < fileUploader.getSize()) {
throw new RuntimeException("文件大小不支持大于10M");
} else {
String fileSuffix = fileNameString.substring(fileNameString.lastIndexOf(".") + 1);
String uuid = UUIDUtils.getUuid();
String newFileName = uuid + "." + fileSuffix;
String tmpPath = uploadFilePath + File.separator + newFileName;
File tmpFile = new File(tmpPath);

try {
fileUploader.transferTo(tmpFile);
return tmpFile;
} catch (Exception var8) {
throw new RuntimeException("系统异常:上传失败,请查看日志");
}
}
} else {
throw new RuntimeException("上传文件不能为空");
}
}
```
can you tell me how to solve it

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.