github / github/codeql

Go autobuild tries to download module dependencies twice

Đang mở
#11,991 2 bình luận 0 reaction 0 người được giao Xem trên GitHub
question
Ngôn ngữ chính
CodeQL
Star
10.1k
Fork
2.1k
Merge trung bình
2 ngày 15 giờ
Pull request đã merge (30 ngày)
141

Mô tả

**Description of the issue**

I noticed [in my Go project](https://github.com/CrunchyData/postgres-operator/actions/runs/3999162447/jobs/6862717663) that autobuild successfully downloads Go modules then reports `Dependencies are still not resolving after the build`.

```

2023/01/24 18:14:22 Found go.mod, enabling go modules
go: downloading k8s.io/api v0.24.2
go: downloading k8s.io/apimachinery v0.24.2
go: downloading k8s.io/client-go v0.24.2

2023/01/24 18:14:32 Import path is 'github.com/CrunchyData/postgres-operator'
2023/01/24 18:14:32 Makefile found.
2023/01/24 18:14:32 Trying build command make []

2023/01/24 18:14:33 Dependencies are still not resolving after the build, continuing to install dependencies.
2023/01/24 18:14:33 Installing dependencies using `go get -v ./...`.
2023/01/24 18:14:35 Running extractor command…

```

🤔 `go mod tidy` downloads dependencies, so I don't expect `go get` needs to be called.

🤔 Is the following code correct? It seems to print `error` exactly when `.DepsErrors` is empty.
https://github.com/github/codeql/blob/07a7a213b3bf02a3408683c18d63b8be0f0474f9/go/extractor/util/util.go#L170-L180

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.