github / github/codeql-cli-binaries
Add `string` predicates `startsWith`, `endsWith` and `contains`
- Langage dominant
- Aucune donnée de langage
- Étoiles
- 1k
- Forks
- 184
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
What do you think about adding predicates to the CodeQL type `string` for determining whether a string has a given prefix or suffix or contains a substring? For example `startsWith(string)`, `endsWith(string)` and `contains(string)`.
Currently the workarounds are using `indexOf(...) = 0` or `matches(...%)` (which seems to be faster than `indexOf`, see https://github.com/github/codeql/issues/6479#issuecomment-900081363). However, these predicates do not convey the intention as clearly, might not be that performant and for `matches` one must take care not to accidentally use `%`or `_` where the intention was to match them literally.
In the github/codeql repository (at https://github.com/github/codeql/commit/39533317ffbeb6224d049de22fc182d8eeea4b61) there are at least:
- 196 cases where `startsWith` could be used
(I searched for the regex `matches\("[^%_]*%"\)` in CodeQL source files)
- 72 cases where `endsWith` could be used
(I searched for the regex `matches\("%[^%_]*"\)` in CodeQL source files)
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
The issue proposes adding startsWith, endsWith, and contains predicates to the CodeQL string type, but names no source files, tests, or implementation entry points. Begin by locating the string type implementation and its tests; done means the predicates are available and cover prefix, suffix, and substring checks without relying on indexOf or matches workarounds.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Domaine
- devtools
- Type d'issue
- Fonctionnalité
- Difficulté
- 5/5
- Temps estimé
- Plus d'une semaine
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 35/100