github-tools / github-tools/github

Unhandled promise rejection when using Repository.isCollaborator()

未關閉
#629 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
JavaScript
星號
3.8k
分支
809
PR 合併指標
30 天內沒有已合併 PR

描述

When calling Repository.isCollaborator(), the a _UnhandledPromiseRejectionWarning: Error: 404 error making request get https://api.github.com/repos/org/repo/collaborators/xxx: "Not Found"_ is thrown when a user is not a collaborator, instead of returning false, and if the user is a collaborator, the request object is returned with blank data field. Based on the documentation, the promise should resolve to a boolean, but this doesn't seem to be the case with how actual behaviour.

貢獻指南

這個儲存庫沒有索引到貢獻指南

研究方向

Start at the Repository.isCollaborator() entry point and reproduce both cases described against the GitHub collaborators endpoint: a non-collaborator and a collaborator. Compare the observed promise result with the documented boolean behavior; done means both cases resolve to the expected boolean without an unhandled rejection.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
javascript
領域
api
Issue 類型
缺陷
難度
3/5
預估耗時
1-2 天
活躍度
停滯
描述清晰度
基本清楚
新手友好度
42/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。