github-tools / github-tools/github

Unhandled promise rejection when using Repository.isCollaborator()

Open
#629 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
3.8k
Forks
809
PR merge metrics
No merged PRs in 30d

Description

When calling Repository.isCollaborator(), the a _UnhandledPromiseRejectionWarning: Error: 404 error making request get https://api.github.com/repos/org/repo/collaborators/xxx: "Not Found"_ is thrown when a user is not a collaborator, instead of returning false, and if the user is a collaborator, the request object is returned with blank data field. Based on the documentation, the promise should resolve to a boolean, but this doesn't seem to be the case with how actual behaviour.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the Repository.isCollaborator() entry point and reproduce both cases described against the GitHub collaborators endpoint: a non-collaborator and a collaborator. Compare the observed promise result with the documented boolean behavior; done means both cases resolve to the expected boolean without an unhandled rejection.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.