github-tools / github-tools/github
Cannot read property 'status' of undefined error when there is no network
- Lenguaje dominante
- JavaScript
- Estrellas
- 3.8k
- Forks
- 809
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
When there is no network the `_request` function fails, without rejecting the Promise, which makes impossible to catch the error when using a callback.
Even though the component can't be used without the network (#388), I think would be good to handle the case.
The error:
`TypeError: Cannot read property 'status' of undefined`
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Línea de trabajo
Start by locating the `_request` function and reproduce the no-network case described in the issue. Check the related context in issue #388, then ensure the failed request rejects its Promise so callback users can catch the error; done means the undefined `status` error is handled instead of escaping.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- javascript
- Área
- api
- Tipo de issue
- Error
- Dificultad
- 2/5
- Tiempo estimado
- 1-3 horas
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 42/100