github-tools / github-tools/github
Cannot read property 'status' of undefined error when there is no network
Open
bug
- Dominant language
- JavaScript
- Stars
- 3.8k
- Forks
- 809
- PR merge metrics
- No merged PRs in 30d
Description
When there is no network the `_request` function fails, without rejecting the Promise, which makes impossible to catch the error when using a callback.
Even though the component can't be used without the network (#388), I think would be good to handle the case.
The error:
`TypeError: Cannot read property 'status' of undefined`
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.