github-tools / github-tools/github

Supporting github enterprise

Ouverte
#322 8 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
needs clarification
Langage dominant
JavaScript
Étoiles
3.8k
Forks
809
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Of all the github api libs, I find this one to be the most well written. I've been using it for working with gihub enterprise and it works fine for most gets.

However, it fails on POST/PUT where:
- SSL errors crop up due to enterprise being signed by an internal certificate signing authority
- no ability to pass extra headers

Above 2 can be solved if there was a way to pass on additional headers for the request. Currently I'm using request-promise and passing the CA chain as well as custom headers when POST/PUT are needed but this is sub optimal solution.

I'm using this in a Node (v4.4.3 and above) app.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Piste de recherche

No files or tests are named. Start by tracing how POST and PUT requests are constructed, then review the existing request-promise usage and how request options could carry a CA chain and additional headers; done means Enterprise POST/PUT requests can use both without the reported SSL failures.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
javascript, node.js
Domaine
api
Type d'issue
Fonctionnalité
Difficulté
4/5
Temps estimé
3-5 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
35/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.