github-tools / github-tools/github

Supporting github enterprise

Abierto
#322 8 comentarios 0 reacciones 0 asignados Ver en GitHub
needs clarification
Lenguaje dominante
JavaScript
Estrellas
3.8k
Forks
809
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Of all the github api libs, I find this one to be the most well written. I've been using it for working with gihub enterprise and it works fine for most gets.

However, it fails on POST/PUT where:
- SSL errors crop up due to enterprise being signed by an internal certificate signing authority
- no ability to pass extra headers

Above 2 can be solved if there was a way to pass on additional headers for the request. Currently I'm using request-promise and passing the CA chain as well as custom headers when POST/PUT are needed but this is sub optimal solution.

I'm using this in a Node (v4.4.3 and above) app.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Línea de trabajo

No files or tests are named. Start by tracing how POST and PUT requests are constructed, then review the existing request-promise usage and how request options could carry a CA chain and additional headers; done means Enterprise POST/PUT requests can use both without the reported SSL failures.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
javascript, node.js
Área
api
Tipo de issue
Nueva funcionalidad
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.